Dandandan commented on code in PR #21083:
URL: https://github.com/apache/datafusion/pull/21083#discussion_r2968080684
##########
datafusion/functions-nested/src/sort.rs:
##########
@@ -148,7 +152,7 @@ impl ScalarUDFImpl for ArraySort {
}
}
-fn array_sort_inner(args: &[ArrayRef]) -> Result<ArrayRef> {
+pub fn array_sort_inner(args: &[ArrayRef]) -> Result<ArrayRef> {
Review Comment:
Claude flagged this:
``` 4. array_sort_inner made pub just for benchmarks```
Solution which could I think could work
- [...] restructuring the benchmark to use the public ArraySort UDF instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
