alamb commented on PR #21054:
URL: https://github.com/apache/datafusion/pull/21054#issuecomment-4103308451
> Hi @alamb , may I ask if this PR of mine is needed?
I think fixing correctness bugs is always apprecaited. THank you very much
In general it would help I think to create a ticket with a SQL reproducer so
it is easier to see that your PRs are fixing bugs.
Ideally it would also include some evidence that DataFusion behavior doesn't
match postgres
You provide this SQL
```sql
SELECT struct(7521, 30) IN (struct(7521, NULL))
```
But that query doesn't run in postgres
```sql
andrewlamb@Andrews-MacBook-Pro-3:~/Downloads/apache-arrow-rs-58.1.0$ psql -h
localhost -U postgres
psql (14.22 (Homebrew), server 11.16 (Debian 11.16-1.pgdg90+1))
Type "help" for help.
postgres=# SELECT struct(7521, 30) IN (struct(7521, NULL))
;
ERROR: function struct(integer, integer) does not exist
LINE 1: SELECT struct(7521, 30) IN (struct(7521, NULL))
^
HINT: No function matches the given name and argument types. You might need
to add explicit type casts.
```
It would help review this PR faster for correctness if you could provide a
sql query showing postgres getting different answers than DataFusion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
