alamb commented on issue #20969: URL: https://github.com/apache/datafusion/issues/20969#issuecomment-4106206264
> Then as a next step I can introduce schema validation to `try_new_from_array` same as `try_new` such that we can check type mismatches early. > > WDYT [@alamb](https://github.com/alamb) ? This sounds about right to me The basic idea of this ticket, in my opinion, is to: 1. Clearly document any requirements on the types of `needle` and `haystack` 2. Ensure the test and code follow those requirements The easiest behavior to reason about I think would be if `needle` and `haystack` had to be exactly the same type, which I think is similar to most of the other operators in DataFusion However, I am not sure what the implications of enforcing that would be -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
