andygrove commented on PR #3759: URL: https://github.com/apache/datafusion-comet/pull/3759#issuecomment-4106486628
Thanks for working on this @vaibhawvipul. This looks like a good start. Note that the behavior does vary between Spark versions. Spark 4 is much more permissive, for example. Could you add end-to-end integration tests, ideally using the new [SQL file based testing](https://datafusion.apache.org/comet/contributor-guide/sql-file-tests.html) approach or with Scale tests that compare Comet and Spark behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
