andygrove opened a new issue, #3763:
URL: https://github.com/apache/datafusion-comet/issues/3763
### What is the problem the feature request solves?
`org.apache.comet.rules.EliminateRedundantTransitions` has a check for when
to allow native c2r.
```rust
val useNative = CometConf.COMET_NATIVE_COLUMNAR_TO_ROW_ENABLED.get() &&
CometNativeColumnarToRowExec.supportsSchema(schema) &&
!hasScanUsingMutableBuffers(child)
```
method `hasScanUsingMutableBuffers` should no longer be needed since mutable
buffers are no longer in the code base.
```rust
private def hasScanUsingMutableBuffers(op: SparkPlan): Boolean = {
op match {
case c: QueryStageExec => hasScanUsingMutableBuffers(c.plan)
case c: ReusedExchangeExec => hasScanUsingMutableBuffers(c.child)
case _ =>
op.exists {
case scan: CometScanExec =>
scan.scanImpl == CometConf.SCAN_NATIVE_ICEBERG_COMPAT &&
scan.relation.partitionSchema.nonEmpty
case _ => false
}
}
}
```
### Describe the potential solution
_No response_
### Additional context
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
