andygrove commented on code in PR #11534:
URL: https://github.com/apache/datafusion/pull/11534#discussion_r1683044684
##########
datafusion/physical-expr/src/expressions/case.rs:
##########
@@ -32,10 +32,29 @@ use datafusion_common::cast::as_boolean_array;
use datafusion_common::{exec_err, internal_err, DataFusionError, Result,
ScalarValue};
use datafusion_expr::ColumnarValue;
+use datafusion_physical_expr_common::expressions::column::Column;
use itertools::Itertools;
type WhenThen = (Arc<dyn PhysicalExpr>, Arc<dyn PhysicalExpr>);
+#[derive(Debug, Hash)]
+enum EvalMethod {
+ /// CASE WHEN condition THEN result
+ /// [WHEN ...]
+ /// [ELSE result]
+ /// END
+ CaseNoExpression,
+ /// CASE expression
+ /// WHEN value THEN result
+ /// [WHEN ...]
+ /// [ELSE result]
+ /// END
+ CaseWithExpression,
+ /// This is a specialization for a specific use case where we can take a
fast path
+ /// CASE WHEN condition THEN column [ELSE NULL] END
Review Comment:
I don't think DataFusion has an `if/else` expression. We have one in Comet
that could be upstreamed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
