Samyak2 commented on code in PR #20500:
URL: https://github.com/apache/datafusion/pull/20500#discussion_r2971928047
##########
datafusion/physical-plan/src/repartition/mod.rs:
##########
@@ -2602,6 +2642,31 @@ mod tests {
Ok(())
}
+
+ #[tokio::test]
+ async fn hash_repartition_string_view_compaction() -> Result<()> {
Review Comment:
I've updated the test, please take a look!
Without the fix, the mem usage blows up to 4x of the original size. With the
fix, it's actually less than the original size. To have some margin for error,
I have used a threshold of 2x for the mem usage assertion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
