vaibhawvipul opened a new pull request, #3766:
URL: https://github.com/apache/datafusion-comet/pull/3766
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #961 .
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
SumDecimal and AvgDecimal hardcode nullable=true, which is correct in
non-ANSI mode where overflows produce null values. However, in ANSI mode
overflows throw exceptions instead. If the input is non-nullable, the result
should also be non-nullable in ANSI mode since there is no code path that can
produce a null.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
- Added `input_nullable field` to SumDecimal and AvgDecimal structs,
determined from the child expression's nullability in the planner.
- `is_nullable()` now returns true only in non-ANSI mode or when the input
is nullable. In ANSI mode with non-nullable input, it returns false.
## How are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
Added a test in `CometAggregateSuite` that exercises SUM and AVG on decimal
columns with both nullable and non-nullable inputs, under both ANSI and
non-ANSI modes, using checkSparkAnswerAndOperator to verify results match Spark.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
