2010YOUY01 opened a new pull request, #21108: URL: https://github.com/apache/datafusion/pull/21108
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> Follow up to https://github.com/apache/datafusion/pull/20838 ## Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> in #20838 it adds a way to check and warn about dangling config settings, it has detected several existing violations but has not fixed them. This PR does 1. Fix all the old violations 2. For future slt dangling configurations, it fails the test run instead of only warn about it. I tried to add a config statement at the end of one `slt` file, and run the test, it runs and failed as expected ```sh yongting@Yongtings-MacBook-Pro-2 ~/C/datafusion (cleanup-slt)> cargo test --profile=ci --test sqllogictests Finished `ci` profile [unoptimized] target(s) in 0.18s Running bin/sqllogictests.rs (target/ci/deps/sqllogictests-7e2a8cc6115b158a) Running with 14 test threads (available parallelism: 14) Completed 416 test files in 5 seconds External error: Other Error: SLT file sort_pushdown.slt left modified configuration datafusion.optimizer.max_passes: 3 -> 10 Error: Execution("1 failures") error: test failed, to rerun pass `-p datafusion-sqllogictest --test sqllogictests` ``` ## What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> ## Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 4. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> UT ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> no -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
