coderfender commented on code in PR #21101: URL: https://github.com/apache/datafusion/pull/21101#discussion_r2973004438
########## datafusion/sqllogictest/test_files/array.slt: ########## @@ -1551,6 +1551,44 @@ NULL query error DataFusion error: Error during planning: 'array_max' does not support zero arguments select array_max(); +# array_max over multiple rows (exercises the offsets-based iteration) +query I +select array_max(column1) from (values + (make_array(1, 5, 3)), + (make_array(10, 2, 8)), + (NULL), + (make_array(NULL, 7, NULL)), + (make_array(100)) +) as t(column1); +---- +5 +10 +NULL +7 +100 Review Comment: nit : perhaps we could also validate the result's datatype ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
