parthchandra opened a new pull request, #3780: URL: https://github.com/apache/datafusion-comet/pull/3780
## Which issue does this PR close? Closes # https://github.com/apache/datafusion-comet/issues/3776 ## Rationale for this change Spark `DateTimeUtilsSuite` has many useful tests for string to date and string to timestamp casts which are not being called because they are in the sql/catalyst subproject and are not part of Comet CI. ## What changes are included in this PR? Adds a new test suite to replicate the relevant tests in Comet. The tests pass because the string to timestamp casts are currently marked as invalid and we fall back to Spark. Once all string formats are implemented and the casts are not marked incompatible, these tests will test the native implementation. The tests currently use `checkSparkAnswer` and once all formats are supported the tests can be changed to use `checkSparkAnswerAndOperator` ## How are these changes tested? By running the tests themselves. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
