alamb commented on code in PR #11514:
URL: https://github.com/apache/datafusion/pull/11514#discussion_r1683456227
##########
benchmarks/src/util/options.rs:
##########
@@ -37,6 +37,10 @@ pub struct CommonOpt {
/// Activate debug mode to see more details
#[structopt(short, long)]
pub debug: bool,
+
+ /// If true, will use StringView/BinaryViewArray instead of
String/BinaryArray.
Review Comment:
```suggestion
/// If true, will use StringView/BinaryViewArray instead of
String/BinaryArray
/// when reading ParquetFiles
```
##########
datafusion/common/src/config.rs:
##########
@@ -311,6 +311,10 @@ config_namespace! {
/// Should DataFusion keep the columns used for partition_by in the
output RecordBatches
pub keep_partition_by_columns: bool, default = false
+
+ /// If true, the parquet reader will replace `Utf8/Utf8Large` with
`Utf8View`,
Review Comment:
I think this config option only applies to Parquet at the moment, rather
than applying in a general to execution
What do you think about putting them on the ParquetOptions struct instead?
https://github.com/apache/datafusion/blob/4dd8532e6cd52c480a29a7851c6676a69f261545/datafusion/common/src/config.rs#L323
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
