kevinjqliu commented on code in PR #1443:
URL:
https://github.com/apache/datafusion-python/pull/1443#discussion_r2989385186
##########
.github/workflows/build.yml:
##########
@@ -228,7 +228,10 @@ jobs:
- name: Build (release mode)
uses: PyO3/maturin-action@v1
- if: inputs.build_mode == 'release'
+ # temporarily comment out to verify it works in the PR
+ # if: inputs.build_mode == 'release'
+ env:
+ CARGO_BUILD_JOBS: 2
Review Comment:
this should help, we can even do `CARGO_BUILD_JOBS=1` and also add it to the
"debug" mode below on L241
##########
Cargo.toml:
##########
@@ -67,6 +67,10 @@ datafusion-python-util = { path = "crates/util" }
lto = true
codegen-units = 1
+[profile.release.package.substrait]
+opt-level = 1
+codegen-units = 16
+
Review Comment:
Lets see if scoping it to `substrait` will help here.
I think we might need to bite the bullet and do this:
```
[profile.release]
lto = "thin"
codegen-units = 4
```
or override the options using env var just for that one job.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
