alamb commented on code in PR #11519:
URL: https://github.com/apache/datafusion/pull/11519#discussion_r1683500184
##########
datafusion/physical-plan/src/aggregates/group_values/mod.rs:
##########
@@ -67,17 +69,26 @@ pub fn new_group_values(schema: SchemaRef) ->
Result<Box<dyn GroupValues>> {
_ => {}
}
- if let DataType::Utf8 = d {
- return Ok(Box::new(GroupValuesByes::<i32>::new(OutputType::Utf8)));
- }
- if let DataType::LargeUtf8 = d {
- return Ok(Box::new(GroupValuesByes::<i64>::new(OutputType::Utf8)));
- }
- if let DataType::Binary = d {
- return
Ok(Box::new(GroupValuesByes::<i32>::new(OutputType::Binary)));
- }
- if let DataType::LargeBinary = d {
- return
Ok(Box::new(GroupValuesByes::<i64>::new(OutputType::Binary)));
+ match d {
Review Comment:
👏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
