neilconway opened a new issue, #21156: URL: https://github.com/apache/datafusion/issues/21156
### Is your feature request related to a problem or challenge? We currently copy every input string in `update_batch` for `StringAggGroupsAccumulator`. We could instead just bump the Arc refcount on the input batch and keep `<group_id, batch_id, row_id>` triples. Then assemble the actual results in `evaluate()` (this is similar to #20504 for `array_agg`). This would be quite a bit more complicated than the current approach, but it could be worth it to reduce the amount of data being copied. Note that the current string_agg benchmark uses 3 byte strings, so it would underestimate the impact of this optimization. ### Describe the solution you'd like _No response_ ### Describe alternatives you've considered _No response_ ### Additional context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
