viirya commented on code in PR #682:
URL: https://github.com/apache/datafusion-comet/pull/682#discussion_r1683535804
##########
common/src/main/java/org/apache/comet/vector/CometVector.java:
##########
@@ -79,14 +79,23 @@ public Decimal getDecimal(int i, int precision, int scale) {
} else {
byte[] bytes = getBinaryDecimal(i);
BigInteger bigInteger = new BigInteger(bytes);
- BigDecimal javaDecimal = new BigDecimal(bigInteger, scale);
Review Comment:
And for native execution, we always enable use_decimal128.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
