andygrove opened a new pull request, #3797: URL: https://github.com/apache/datafusion-comet/pull/3797
## Which issue does this PR close? Closes #. ## Rationale for this change `CometSqlFileTestSuite` supports a `query tolerance=<value>` directive for floating-point queries where small numeric differences are expected. However, the `WithTolerance` mode called `checkSparkAnswerWithTolerance`, which hardcodes `assertCometNative = false`. This meant that all 50+ queries using this directive (covering `sin`, `cos`, `tan`, `asin`, `acos`, `atan`, `atan2`, `sinh`, `cosh`, `tanh`, `exp`, `expm1`, `log`, `log2`, `log10`, `pow`, `sqrt`, `cot`, `stddev`, `variance`, `avg`, `sum`, `corr`, `covariance`) were silently skipping the assertion that Comet actually executed the expression natively. ## What changes are included in this PR? - Add `checkSparkAnswerAndOperatorWithTolerance` to `CometTestBase`, which combines tolerance-based result comparison with `assertCometNative = true`. - Change the `WithTolerance` case in `CometSqlFileTestSuite` to call the new method instead of `checkSparkAnswerWithTolerance`. ## How are these changes tested? The existing SQL file tests for all affected math and aggregate expressions will now enforce native execution as part of their normal CI run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
