adriangb commented on code in PR #20455:
URL: https://github.com/apache/datafusion/pull/20455#discussion_r2991466491
##########
datafusion/physical-plan/src/joins/sort_merge_join/exec.rs:
##########
@@ -594,4 +600,56 @@ impl ExecutionPlan for SortMergeJoinExec {
self.null_equality,
)?)))
}
+
+ fn gather_filters_for_pushdown(
+ &self,
+ _phase: FilterPushdownPhase,
+ parent_filters: Vec<Arc<dyn PhysicalExpr>>,
+ _config: &ConfigOptions,
+ ) -> Result<FilterDescription> {
+ // Only support Inner joins for now — other join types have complex
+ // column routing semantics (e.g. nullable sides, semi/anti output
+ // restrictions) that require careful handling.
Review Comment:
Up to you. I have no issue leaving it open and more work gets pushed in a
couple weeks. Longer than that and yeah lets close it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
