gene-bordegaray commented on PR #21152: URL: https://github.com/apache/datafusion/pull/21152#issuecomment-4132810086
> In general, it might be better to keep metrics that directly help application tuning, are frequently used, or are difficult to capture with external profilers. I suspect some of them can be directly observed with profilers/flamegraphs, maybe they can be simplified? > > > > Additionally, we could consider introducing a new analyze level `Internal` in `datafusion.explain.analyze_level` (https://datafusion.apache.org/user-guide/configs.html) to hide these metrics from regular output. Ya I agree and am trying to be wary about this as well. I don't not see any changes on benches but like may be hard to catch microregressions. I am using these and they are quite useful (and very convenient compared to a profiling tool like xctrace). Maybe these could be kept at the 'dev' level of analyze output? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
