gene-bordegaray commented on PR #20901: URL: https://github.com/apache/datafusion/pull/20901#issuecomment-4132903663
> IMHO, If we had a way of contributing functionality to dynamic filters without necessarily touching the very core of DataFusion, the flow of these contributions would be much smoother, and I could imagine how representing dynamic filters, not as `PhysicalExpr` implementations, but as first class `DynamicFilter` structs, has good chances of delivering such vision. Trino's representation of dynamic filters is much more explicit which avoids a lot of one off behavior for PhysicalExpr. To Adrian's question if we were to explore a new design how long would we have to support the PhysicalExpr approach? I don't know the exact scenario but like it would get hairy if users are using the public API for a PhysicalExpr in one run filter and a implicitly uses a first class DynamicFilter in another. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
