UBarney commented on code in PR #21090:
URL: https://github.com/apache/datafusion/pull/21090#discussion_r2994941334
##########
datafusion/functions-aggregate/src/first_last.rs:
##########
@@ -183,110 +365,14 @@ impl AggregateUDFImpl for FirstValue {
}
fn groups_accumulator_supported(&self, args: AccumulatorArgs) -> bool {
- use DataType::*;
- !args.order_bys.is_empty()
Review Comment:
We might want to consider adding a new `GroupsAccumulator` to handle cases
without `ORDER BY,` or perhaps implement a fast path in
`FirstLastGroupsAccumulator` for when no ordering is required
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
