jayzhan211 commented on code in PR #11448:
URL: https://github.com/apache/datafusion/pull/11448#discussion_r1683609423
##########
datafusion/proto/src/physical_plan/to_proto.rs:
##########
@@ -260,14 +259,9 @@ struct AggrFn {
fn aggr_expr_to_aggr_fn(expr: &dyn AggregateExpr) -> Result<AggrFn> {
let aggr_expr = expr.as_any();
- let mut distinct = false;
- let inner = if aggr_expr.downcast_ref::<ArrayAgg>().is_some() {
- protobuf::AggregateFunction::ArrayAgg
- } else if aggr_expr.downcast_ref::<DistinctArrayAgg>().is_some() {
- distinct = true;
- protobuf::AggregateFunction::ArrayAgg
- } else if aggr_expr.downcast_ref::<OrderSensitiveArrayAgg>().is_some() {
+ // TODO: remove
Review Comment:
OrderSensitiveArrayAgg is not yet removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
