itsjunetime opened a new pull request, #11540: URL: https://github.com/apache/datafusion/pull/11540
## Which issue does this PR close? Closes #11529 ## Rationale for this change This is a very simple implementation for the change suggested in #11529, and is easy to review and comprehend. ## What changes are included in this PR? This causes datafusion to return an error when someone attempts to execute a command that contains a `SHOW` statement whose variable does not exist in the `information_schema.df_settings` table. This provides a better UX for the user, as they get told exactly what's going on (with a clear error) when they execute this command, instead of getting an empty table as the result (which was happening previously). ## Are these changes tested? Yes - Additions were made to the sqllogictest tests to cover the use case addressed here. ## Are there any user-facing changes? I think this counts as a user-facing change - it would be easy to rely on the behavior of "SHOW <variable> will return an empty result if <variable> doesn't exist" and so it's very possible someone does rely on that. I'd be happy to update documentation if that's necessary with this change, though I'm somewhat uncertain as to whether this warrants that - the previous behavior wasn't specified in docs, so I don't know if it is necessary here. It probably couldn't hurt, I think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
