asolimando commented on code in PR #21077: URL: https://github.com/apache/datafusion/pull/21077#discussion_r2996530676
########## datafusion/sqllogictest/test_files/parquet_statistics.slt: ########## @@ -59,7 +59,7 @@ query TT EXPLAIN SELECT * FROM test_table WHERE column1 = 1; Review Comment: No worries, re-reading your comment it was pretty clear already, I think this is on me! I have added tests to the same file in 0613f1af4f71e56442ad154e0aede0a41698cd62, but over a different (single file) table, the use case for single table/multiple files being covered by the first test, I hope I have captured your intention. I took [dictionary.slt#L34](https://github.com/apache/datafusion/blob/ba399a80f9ffcb0563adf2b67add13d0476f6291/datafusion/sqllogictest/test_files/dictionary.slt#L34) as a reference on how to cast to different numeric types in SLT tests. I haven't dropped https://github.com/apache/datafusion/commit/1531e5cfb55388e3f92643ea6a6f17fdb87d2f11 as I feel it's valuable to have unit tests co-located with the code, but this feels redundant I am OK removing them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
