mbutrovich commented on issue #21165: URL: https://github.com/apache/datafusion/issues/21165#issuecomment-4137328410
Bringing my comment from #21184: > Also I'm not confused where I should add benchmarks. @andygrove added Criterion SMJ benchmarks in #20464, but they're missing ones from dfbench's `smj` benchmarks, which I further extend here. Any help? Each PR I work on SMJ I add more benchmarks to represent problem scenarios we're seeing. But after #20464 I am now confused. Where should I be adding benchmarks, and what will we be using to catch regressions? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
