nuno-faria commented on code in PR #20654:
URL: https://github.com/apache/datafusion/pull/20654#discussion_r2997843779
##########
datafusion/sql/src/unparser/dialect.rs:
##########
@@ -362,6 +366,23 @@ impl Dialect for PostgreSqlDialect {
}
impl PostgreSqlDialect {
+ fn array_has_to_sql_any(
+ &self,
+ unparser: &Unparser,
+ args: &[Expr],
+ ) -> Result<Option<ast::Expr>> {
+ let [haystack, needle] = args else {
+ return Ok(None);
+ };
Review Comment:
nit: Since `args` must always contain `[haystack, needle]` in this case, I
wonder if setting the else to `unreachable!()` would be clearer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
