y-f-u commented on code in PR #11527:
URL: https://github.com/apache/datafusion/pull/11527#discussion_r1683716730
##########
datafusion/sql/tests/cases/plan_to_sql.rs:
##########
@@ -240,6 +240,63 @@ fn roundtrip_statement_with_dialect() -> Result<()> {
parser_dialect: Box::new(GenericDialect {}),
unparser_dialect: Box::new(UnparserDefaultDialect {}),
},
+ TestStatementWithDialect {
+ sql: "SELECT j1_string from j1 order by j1_id",
Review Comment:
added to the test suite
##########
datafusion/sql/tests/cases/plan_to_sql.rs:
##########
@@ -240,6 +240,63 @@ fn roundtrip_statement_with_dialect() -> Result<()> {
parser_dialect: Box::new(GenericDialect {}),
unparser_dialect: Box::new(UnparserDefaultDialect {}),
},
+ TestStatementWithDialect {
+ sql: "SELECT j1_string from j1 order by j1_id",
+ expected: r#"SELECT j1.j1_string FROM j1 ORDER BY j1.j1_id ASC
NULLS LAST"#,
+ parser_dialect: Box::new(GenericDialect {}),
+ unparser_dialect: Box::new(UnparserDefaultDialect {}),
+ },
+ // Test query with derived tables that put distinct,sort,limit on the
wrong level
Review Comment:
added to the test suite
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
