RamakrishnaChilaka commented on code in PR #21177:
URL: https://github.com/apache/datafusion/pull/21177#discussion_r2999035236
##########
datafusion/datasource/src/memory.rs:
##########
@@ -897,6 +897,42 @@ mod tests {
Ok(())
}
+ /// Test that `try_swapping_with_projection` preserves the `fetch` limit.
+ /// Regression test for <https://github.com/apache/datafusion/issues/21176>
+ #[test]
+ fn try_swapping_with_projection_preserves_fetch() {
+ use datafusion_physical_expr::projection::ProjectionExprs;
+
+ let schema = Arc::new(Schema::new(vec![
+ Field::new("a", DataType::Int32, false),
+ Field::new("b", DataType::Utf8, false),
+ Field::new("c", DataType::Int64, false),
+ ]));
+ let partitions: Vec<Vec<RecordBatch>> = vec![vec![batch(10)]];
+ let source = MemorySourceConfig::try_new(&partitions, schema.clone(),
None)
+ .unwrap()
+ .with_limit(Some(5));
+
+ assert_eq!(source.fetch, Some(5));
+
+ // Create a projection that reorders columns: [c, a] (indices 2, 0)
+ let projection = ProjectionExprs::from_indices(&[2, 0], &schema);
+ let swapped = source
+ .try_swapping_with_projection(&projection)
+ .unwrap()
+ .expect("should return Some");
Review Comment:
ack, updated to use `.unwrap()` consistently throughout the test. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
