y-f-u commented on code in PR #11505:
URL: https://github.com/apache/datafusion/pull/11505#discussion_r1683736161


##########
datafusion/sql/tests/cases/plan_to_sql.rs:
##########
@@ -240,6 +240,35 @@ fn roundtrip_statement_with_dialect() -> Result<()> {
             parser_dialect: Box::new(GenericDialect {}),
             unparser_dialect: Box::new(UnparserDefaultDialect {}),
         },
+        // more tests around subquery/derived table roundtrip
+        TestStatementWithDialect {
+            sql: "SELECT string_count FROM (
+                    SELECT

Review Comment:
   Thanks for the suggestion. This query is actually not working as "CAST" will 
be presented in the inner projection and the projections matching actually 
breaks.
   
   Maybe another PR to fix this case.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to