2010YOUY01 commented on code in PR #11533:
URL: https://github.com/apache/datafusion/pull/11533#discussion_r1683764579
##########
datafusion/common/src/config.rs:
##########
@@ -184,6 +184,10 @@ config_namespace! {
/// Default value for `format.has_header` for `CREATE EXTERNAL TABLE`
/// if not specified explicitly in the statement.
pub has_header: bool, default = false
+
+ /// Default value for `format.newlines_in_values` for `CREATE EXTERNAL
TABLE`
+ // if not specified explicitly in the statement.
Review Comment:
We need more descriptive comment help for users without context to
understand this config option, which should include 1. It's CSV specific 2. Can
be overridden by the same config field in `CsvOptions` 3. Its behavior as
stated in `CsvOptions`'s comment.
And update in
https://github.com/apache/datafusion/blob/main/docs/source/user-guide/configs.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
