mbutrovich commented on code in PR #21184:
URL: https://github.com/apache/datafusion/pull/21184#discussion_r3002762133
##########
datafusion/physical-plan/src/joins/sort_merge_join/metrics.rs:
##########
@@ -35,8 +34,6 @@ pub(super) struct SortMergeJoinMetrics {
/// Peak memory used for buffered data.
/// Calculated as sum of peak memory values across partitions
peak_mem_used: Gauge,
- /// Metrics related to spilling
- spill_metrics: SpillMetrics,
Review Comment:
Moved `SpillMetrics` construction from `SortMergeJoinMetrics` into `exec.rs`
where the `SpillManager` is now built (shared across both streams). The metrics
are still registered into the same `ExecutionPlanMetricsSet` and reported via
`metrics()` — just constructed in a
different place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
