andygrove opened a new pull request, #3818: URL: https://github.com/apache/datafusion-comet/pull/3818
## Which issue does this PR close? N/A - cleanup ## Rationale for this change The `SupportsComet` Java interface was designed for a patched version of Apache Iceberg to signal Comet compatibility. Iceberg scans are now detected by class name (`SparkBatchQueryScan`), making this interface and its associated code path in `CometScanRule` unnecessary. ## What changes are included in this PR? - Deleted the `SupportsComet` Java interface from `common/` - Removed the `case s: SupportsComet` match arm in `CometScanRule.scala` that handled patched Iceberg builds - Removed the `SupportsComet` import from `CometScanRule.scala` - Updated a comment in `CometExecRule.scala` that referenced `SupportsComet` ## How are these changes tested? The class-name-based Iceberg detection path (`SparkBatchQueryScan`) is unchanged and continues to handle all Iceberg scans. Existing Iceberg integration tests cover this path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
