askalt commented on code in PR #20222:
URL: https://github.com/apache/datafusion/pull/20222#discussion_r3006699899
##########
datafusion/ffi/src/udtf.rs:
##########
@@ -215,13 +273,32 @@ impl From<FFI_TableFunction> for Arc<dyn
TableFunctionImpl> {
}
impl TableFunctionImpl for ForeignTableFunction {
- fn call(&self, args: &[Expr]) -> Result<Arc<dyn TableProvider>> {
+ fn call_with_args(&self, args: TableFunctionArgs) -> Result<Arc<dyn
TableProvider>> {
+ let session =
+ FFI_SessionRef::new(args.session, None,
self.0.logical_codec.clone());
Review Comment:
Fixed. Now it is passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
