comphead commented on code in PR #3842:
URL: https://github.com/apache/datafusion-comet/pull/3842#discussion_r3012546144
##########
spark/src/main/scala/org/apache/spark/sql/comet/CometMetricNode.scala:
##########
@@ -79,10 +79,21 @@ case class CometMetricNode(metrics: Map[String, SQLMetric],
children: Seq[CometM
}
}
+ // Called via JNI from `comet_metric_node.rs`
def set_all_from_bytes(bytes: Array[Byte]): Unit = {
val metricNode = Metric.NativeMetricNode.parseFrom(bytes)
set_all(metricNode)
}
+
+ /**
+ * Finds a metric by name in this node or any descendant node. Returns the
first match found via
+ * depth-first search.
+ */
+ def findMetric(name: String): Option[SQLMetric] = {
+ metrics.get(name).orElse {
+ children.iterator.map(_.findMetric(name)).collectFirst { case Some(m) =>
m }
Review Comment:
mm, what if we try to restrict `output_rows` to scan nodes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
