alamb commented on code in PR #11536:
URL: https://github.com/apache/datafusion/pull/11536#discussion_r1684926587
##########
datafusion/physical-expr/src/expressions/column.rs:
##########
@@ -95,11 +94,10 @@ impl PhysicalExpr for UnKnownColumn {
}
impl PartialEq<dyn Any> for UnKnownColumn {
- fn eq(&self, other: &dyn Any) -> bool {
- down_cast_any_ref(other)
- .downcast_ref::<Self>()
- .map(|x| self == x)
- .unwrap_or(false)
+ fn eq(&self, _other: &dyn Any) -> bool {
+ // UnknownColumn is not a valid expression, so it should not be equal
to any other expression.
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
