hcrosse opened a new pull request, #21288: URL: https://github.com/apache/datafusion/pull/21288
## Which issue does this PR close? - Closes #14433 ## What changes are included in this PR? Attaches `Diagnostic` (message, note, help) to the `NOT` and `-` error paths in `unary_op.rs`. Also extends `Expr::spans()` to recurse through `Not`/`Negative` so column source locations propagate to the error. `+` already had this, this PR covers the remaining two operators. ## Are these changes tested? Yes, added tests in `diagnostic.rs` for column and non-column operands for both operators. ## Are there any user-facing changes? Error messages for `NOT <non-boolean>` and `- <non-numeric>` now include source location and a fix suggestion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
