Dandandan commented on PR #21240: URL: https://github.com/apache/datafusion/pull/21240#issuecomment-4167529199
I am a bit suprised that it is even needed to do some speculative/overlapping to get performance parity. AFAIK NestedLoopJoinExec doesn't do this (it will execute build side first then probe). In a ideal scenario, we don't do that, as it will might increase the memory usage substantially by executing the pipelines concurrently and make it less cache/NUMA friendly, (we could instead improve parallelism at each individual pipeline e.g. using morsel approach). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
