tobixdev opened a new pull request, #21291: URL: https://github.com/apache/datafusion/pull/21291
## Which issue does this PR close? - Related to https://github.com/apache/datafusion/issues/21144 . ## Rationale for this change Implements `DFExtensionType` for the other canonical extension types (except Parquet types). ## What changes are included in this PR? - Implement `DFExtensionType` for: - `arrow.bool8` (custom formatting with true/false) - `arrow.fixed_shape_tensor` (nu custom formatting for now) - `arrow.json` (no custom formatting for now) - `arrow.opaque` (no custom formatting for now) - `arrow.timestamp_with_offset` (custom formatting as timestamp) - `arrow.variable_shape_tensor` (no custom formatting) - Introduce a wrapper struct `DFUuid` for `Uuid` so that it is consistent with the other extension types. I don't know whether we truly need the wrapper structs for extension types that only have a single valid storage type based on their metadata (e.g., Bool8, Uuid) . Open for any opinions. @paleolimbot Is this the kind of wrapper structs you imagined? Should we also add end-to-end tests for the other extension types? Currently, we only have the UUID one from the last PR. I think for variant supports it's best to wait for general Variant support in DataFusion as this is currently done in https://github.com/datafusion-contrib/datafusion-variant . ## Are these changes tested? Custom formatters are tested. The rest is mainly boiler plate code. ## Are there any user-facing changes? Yes more extension types and renames `Uuid` to `DFUuid`. If we plan to keep our own wrapper structs, we should merge that before releasing a version with the old `Uuid` so we have no breaking changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
