adriangb commented on issue #21290: URL: https://github.com/apache/datafusion/issues/21290#issuecomment-4169969442
> Could you confirm whether `PhysicalExprAdapterFactory` is intended to cover all the same paths that `SchemaAdapterFactory` did? Or is there additional setup needed when creating `ParquetSource` directly? Yes `PhysicalExprAdapterFactory` does cover all of the same cases that `SchemaAdapterFactory` did. There may be some differences in wiring when creating a `ParquetSource` directly (mostly due to refactorings not specifically this change), however I can confirm that the default `PhysicalExprAdapterFactory` is bound even if you don't specify a custom one: https://github.com/apache/datafusion/blob/1416ed4d5007180136dae0aaeb921f0681ec001e/datafusion/datasource-parquet/src/source.rs#L519-L522 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
