kosiew commented on code in PR #21068: URL: https://github.com/apache/datafusion/pull/21068#discussion_r3026168085
########## datafusion/physical-plan/src/joins/utils.rs: ########## Review Comment: The state-machine hoist should let us skip `process_probe_batch` entirely for the join types whose output is fixed to empty once the build side is empty. I don't think we can delete `build_batch_empty_build_side`, though, because it is still needed for `Right`, `Full`, `RightAnti`, and `RightMark`: those joins must keep consuming probe batches and synthesize rows from them when the build side is empty. What we probably can do is narrow the remaining `process_probe_batch` branch so it is clearly only the "probe rows still matter" path, instead of looking like it is duplicating the new early-exit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
