alamb commented on PR #11528:
URL: https://github.com/apache/datafusion/pull/11528#issuecomment-2240252720

   > The previous behavior was that builtin scalar functions could be pushdown, 
but UDF couldn't. Now all scalar functions are converted to UDF.
   
   
   I think we should pushdown UDF functions into cross join unless there is 
some reason not to. 
   
   I suspect the reason they were not being pushed down before was simply an 
oversight rather than a conscious decision
   
   I agree with @simonvandel that ensuring this is covered by tests (if 
existing tests need to be updated that shows the change is covered). 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to