andygrove commented on code in PR #693:
URL: https://github.com/apache/datafusion-comet/pull/693#discussion_r1685038100
##########
common/src/main/spark-3.3/org/apache/comet/shims/ShimBatchReader.scala:
##########
@@ -33,4 +37,24 @@ object ShimBatchReader {
Array.empty[String],
0,
0)
+
+ def getTaskAccumulator(taskMetrics: TaskMetrics): Option[AccumulatorV2[_,
_]] = {
Review Comment:
This looks good, but it seems to be the same implementation in all of the
shims? Deos it even need to be in the shim layer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
