comphead commented on code in PR #3876:
URL: https://github.com/apache/datafusion-comet/pull/3876#discussion_r3030559090
##########
spark/src/main/scala/org/apache/spark/sql/comet/CometWindowExec.scala:
##########
@@ -72,7 +72,12 @@ object CometWindowExec extends
CometOperatorSerde[WindowExec] {
return None
}
- if (op.partitionSpec.nonEmpty && op.orderSpec.nonEmpty &&
+ // Offset window functions (LAG, LEAD) support arbitrary partition and
order specs, so skip
Review Comment:
wondering if FIRST_VALUE, LAST_VALUE, NTH are also offset window function,
cause they also access the data within frame by some offset (FiRST_VALUE by 1,
etc) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
