0lai0 opened a new pull request, #3896: URL: https://github.com/apache/datafusion-comet/pull/3896
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> Follow-up to PR #3798 (Fixes Issue #3791). ## Rationale for this change This addresses the post-merge review comments from @comphead in PR #3798 regarding the removal of hardcoded literals in the newly added test for `CometNativeScanExec` metrics. ## What changes are included in this PR? - Extracted the hardcoded `2` into a well-named `val inputFiles = 2` constant inside the test `"Native_datafusion reports correct files and bytes scanned"`. - Updated the assertions and `repartition()` logic to strictly rely on `inputFiles` for better readability and maintainability. ## How are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> Verified locally by running `CometExecSuite`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
