parthchandra commented on code in PR #3878:
URL: https://github.com/apache/datafusion-comet/pull/3878#discussion_r3034447992
##########
spark/src/test/scala/org/apache/comet/exec/CometExecSuite.scala:
##########
@@ -2173,6 +2173,42 @@ class CometExecSuite extends CometTestBase {
}
}
+ test("LocalTableScanExec with timestamps in non-UTC timezone") {
Review Comment:
Do we need `COMET_SPARK_TO_ARROW_ENABLED` to be set to true for these tests?
##########
common/src/main/scala/org/apache/comet/CometConf.scala:
##########
@@ -222,31 +222,28 @@ object CometConf extends ShimCometConf {
val COMET_CONVERT_FROM_PARQUET_ENABLED: ConfigEntry[Boolean] =
Review Comment:
Are there any test which exercise `COMET_CONVERT_FROM_PARQUET_ENABLED`,
`COMET_CONVERT_FROM_JSON_ENABLED`, and `COMET_CONVERT_FROM_CSV_ENABLED`, since
these will no longer be 'experimental' ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
