alamb commented on code in PR #11539:
URL: https://github.com/apache/datafusion/pull/11539#discussion_r1685385768
##########
datafusion/core/src/datasource/file_format/write/orchestration.rs:
##########
@@ -153,14 +184,17 @@ pub(crate) async fn stateless_serialize_and_write_files(
while let Some(result) = join_set.join_next().await {
match result {
Ok(res) => match res {
- Ok((writer, cnt)) => {
+ SerializedRecordBatchResult::Success {
Review Comment:
I think this is much easier to understand now
##########
datafusion/core/src/datasource/file_format/write/orchestration.rs:
##########
@@ -42,6 +42,37 @@ use tokio::task::JoinSet;
type WriterType = Box<dyn AsyncWrite + Send + Unpin>;
type SerializerType = Arc<dyn BatchSerializer>;
+/// Result of calling [`serialize_rb_stream_to_object_store`]
Review Comment:
👨🍳 👌
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
