adriangb commented on code in PR #21333:
URL: https://github.com/apache/datafusion/pull/21333#discussion_r3035568693
##########
datafusion/sqllogictest/test_files/clickbench.slt:
##########
@@ -717,10 +716,9 @@ physical_plan
01)ProjectionExec: expr=[SearchPhrase@0 as SearchPhrase]
02)--SortPreservingMergeExec: [EventTime@1 ASC NULLS LAST, SearchPhrase@0 ASC
NULLS LAST], fetch=10
03)----SortExec: TopK(fetch=10), expr=[EventTime@1 ASC NULLS LAST,
SearchPhrase@0 ASC NULLS LAST], preserve_partitioning=[true]
-04)------ProjectionExec: expr=[SearchPhrase@1 as SearchPhrase, EventTime@0 as
EventTime]
-05)--------FilterExec: SearchPhrase@1 !=
-06)----------RepartitionExec: partitioning=RoundRobinBatch(4),
input_partitions=1
-07)------------DataSourceExec: file_groups={1 group:
[[WORKSPACE_ROOT/datafusion/core/tests/data/clickbench_hits_10.parquet]]},
projection=[EventTime, SearchPhrase], file_type=parquet,
predicate=SearchPhrase@39 != AND DynamicFilter [ empty ],
pruning_predicate=SearchPhrase_null_count@2 != row_count@3 AND
(SearchPhrase_min@0 != OR != SearchPhrase_max@1),
required_guarantees=[SearchPhrase not in ()]
+04)------FilterExec: SearchPhrase@1 != , projection=[SearchPhrase@1,
EventTime@0]
Review Comment:
Nice this one did get eliminated
##########
datafusion/sqllogictest/test_files/dynamic_filter_pushdown_config.slt:
##########
@@ -155,10 +155,9 @@ logical_plan
05)----SubqueryAlias: r
06)------TableScan: right_parquet projection=[id, info]
physical_plan
-01)ProjectionExec: expr=[id@1 as id, data@2 as data, info@0 as info]
-02)--HashJoinExec: mode=CollectLeft, join_type=Inner, on=[(id@0, id@0)],
projection=[info@1, id@2, data@3]
-03)----DataSourceExec: file_groups={1 group:
[[WORKSPACE_ROOT/datafusion/sqllogictest/test_files/scratch/dynamic_filter_pushdown_config/join_right.parquet]]},
projection=[id, info], file_type=parquet
-04)----DataSourceExec: file_groups={1 group:
[[WORKSPACE_ROOT/datafusion/sqllogictest/test_files/scratch/dynamic_filter_pushdown_config/join_left.parquet]]},
projection=[id, data], file_type=parquet, predicate=DynamicFilter [ empty ]
+01)HashJoinExec: mode=CollectLeft, join_type=Inner, on=[(id@0, id@0)],
projection=[id@2, data@3, info@1]
Review Comment:
Another one bites the dust...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
