adriangb commented on code in PR #21157:
URL: https://github.com/apache/datafusion/pull/21157#discussion_r3035913761
##########
datafusion-examples/examples/data_io/parquet_index.rs:
##########
@@ -462,7 +462,7 @@ impl PruningStatistics for ParquetMetadataIndex {
}
/// return the row counts for each file
- fn row_counts(&self, _column: &Column) -> Option<ArrayRef> {
+ fn row_counts(&self) -> Option<ArrayRef> {
Review Comment:
This ends up having a lot of ramifications. IMO the existing API is flawed
and we should fix it. I'm happy to do this in an isolated PR, but it does make
the rest of this work much simpler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
