adriangb commented on code in PR #21322: URL: https://github.com/apache/datafusion/pull/21322#discussion_r3037426317
########## datafusion/sqllogictest/test_files/cast_to_type.slt: ########## @@ -0,0 +1,316 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +####### +## Tests for cast_to_type function +####### + +# Basic string to integer cast +query I +SELECT cast_to_type('42', NULL::INTEGER); +---- +42 + +# String to double cast +query R +SELECT cast_to_type('3.14', NULL::DOUBLE); +---- +3.14 + +# Integer to string cast +query T +SELECT cast_to_type(42, NULL::VARCHAR); +---- +42 + +# Integer to double cast +query R +SELECT cast_to_type(42, NULL::DOUBLE); +---- +42 + +# Same-type is a no-op +query I +SELECT cast_to_type(42, 0::INTEGER); +---- +42 + +# NULL first argument +query I +SELECT cast_to_type(NULL, 0::INTEGER); +---- +NULL + +# NULL reference (type still applies) +query I +SELECT cast_to_type('42', NULL::INTEGER); Review Comment: Good catch. The intention was different but being a relatively simple feature it ended up being the exact same test. I've done a pass at trying to improve the tests in 954e029dd. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
