xiedeyantu commented on PR #21362: URL: https://github.com/apache/datafusion/pull/21362#issuecomment-4190193423
> Looks good overall! A few minor suggestions. @neilconway Thank you for your comments and suggestions; I think the scenario you mentioned—changing `order by deptno, total_sal, abs(deptno)` to `order by deptno, abs(deptno)`—is an excellent point. We should definitely support this; our previous restrictions were indeed a bit too strict. We could even go a step further in the future by leveraging injective functions for additional optimizations (though it might be better to implement this in a separate PR). Regarding the rest of your comments, I have attempted to address each one by submitting a corresponding commit. Could you please take another look and review them? Thank you once again for your thorough reviews of every single one of my PRs! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
